refactor(distribution): CLI tests using Tendermint Mock #13692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13692 +/- ##
==========================================
+ Coverage 55.43% 56.00% +0.56%
==========================================
Files 646 646
Lines 55779 55784 +5
==========================================
+ Hits 30922 31240 +318
+ Misses 22341 22003 -338
- Partials 2516 2541 +25
|
julienrbrt
reviewed
Oct 29, 2022
julienrbrt
reviewed
Oct 29, 2022
| @@ -1,4 +1,4 @@ | |||
| package testutil | |||
| package distribution | |||
There was a problem hiding this comment.
Personally, I am confused. Given that it uses depinject, isn't it more an integration test than an e2e test?
cc @kocubinski
…ita/distribution-cli-tests
…ita/distribution-cli-tests
…ita/distribution-cli-tests
…ita/distribution-cli-tests
…ita/distribution-cli-tests
| responseQuery abci.ResponseQuery | ||
| } | ||
|
|
||
| func newMockTendermintRPC(respQuery abci.ResponseQuery) mockTendermintRPC { |
There was a problem hiding this comment.
Probably not for this PR, but could we have this in a single place? I've seen it many times and mayyybe we can centralize it
There was a problem hiding this comment.
Oh yeah that would be great! It should be under testutil/cli as it's used in all CLI tests.
facundomedica
approved these changes
Nov 2, 2022
alexanderbez
approved these changes
Nov 2, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13479
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change