Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(distribution): CLI tests using Tendermint Mock #13692

Merged
merged 16 commits into from
Nov 3, 2022
Merged

refactor(distribution): CLI tests using Tendermint Mock #13692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bcc5842
move distribution cli tests to e2e tests
likhita-809 Oct 29, 2022
25a0847
wip: add cli tests
likhita-809 Oct 29, 2022
ca069bb
Merge branch 'main' into likhita/distribution-cli-tests
julienrbrt Oct 29, 2022
25876ef
wip: remove duplicate helpers.go file
likhita-809 Oct 31, 2022
fb584ec
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Nov 1, 2022
2141da8
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Nov 1, 2022
e590c2b
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Nov 1, 2022
5b0e139
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Nov 2, 2022
583eed5
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Nov 2, 2022
adbbd5d
Merge branch 'main' into likhita/distribution-cli-tests
atheeshp Nov 3, 2022
fb052d0
fix something
likhita-809 Nov 3, 2022
a4dec05
Merge branch 'likhita/distribution-cli-tests' of https://github.com/c…
likhita-809 Nov 3, 2022
80d16b7
Merge branch 'main' into likhita/distribution-cli-tests
likhita-809 Nov 3, 2022
1fe0319
Merge branch 'main' into likhita/distribution-cli-tests
tac0turtle Nov 3, 2022
6187e84
Merge branch 'main' into likhita/distribution-cli-tests
likhita-809 Nov 3, 2022
97f84a0
Merge branch 'main' into likhita/distribution-cli-tests
likhita-809 Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tests/e2e/distribution/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,16 @@ import (
"testing"

"github.com/stretchr/testify/suite"

"github.com/cosmos/cosmos-sdk/x/distribution/client/testutil"
)

func TestIntegrationTestSuite(t *testing.T) {
suite.Run(t, new(testutil.IntegrationTestSuite))
suite.Run(t, new(IntegrationTestSuite))
}

func TestGRPCQueryTestSuite(t *testing.T) {
suite.Run(t, new(testutil.GRPCQueryTestSuite))
suite.Run(t, new(GRPCQueryTestSuite))
}

func TestWithdrawAllSuite(t *testing.T) {
suite.Run(t, new(testutil.WithdrawAllTestSuite))
suite.Run(t, new(WithdrawAllTestSuite))
}
2 changes: 1 addition & 1 deletion ...ution/client/testutil/grpc_query_suite.go → tests/e2e/distribution/grpc_query_suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package testutil
package distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I am confused. Given that it uses depinject, isn't it more an integration test than an e2e test?
cc @kocubinski


import (
"fmt"
Expand Down
5 changes: 3 additions & 2 deletions x/distribution/client/testutil/suite.go → tests/e2e/distribution/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package testutil
package distribution

import (
"encoding/hex"
Expand All @@ -16,6 +16,7 @@ import (
"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/distribution/client/cli"
distrclitestutil "github.com/cosmos/cosmos-sdk/x/distribution/client/testutil"
"github.com/cosmos/cosmos-sdk/x/distribution/testutil"
distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types"
minttypes "github.com/cosmos/cosmos-sdk/x/mint/types"
Expand Down Expand Up @@ -557,7 +558,7 @@ func (s *IntegrationTestSuite) TestNewWithdrawRewardsCmd() {
clientCtx := val.ClientCtx

_, _ = s.network.WaitForHeightWithTimeout(10, time.Minute)
bz, err := MsgWithdrawDelegatorRewardExec(clientCtx, tc.valAddr, tc.args...)
bz, err := distrclitestutil.MsgWithdrawDelegatorRewardExec(clientCtx, tc.valAddr, tc.args...)
if tc.expectErr {
s.Require().Error(err)
} else {
Expand Down
2 changes: 1 addition & 1 deletion ...ion/client/testutil/withdraw_all_suite.go → tests/e2e/distribution/withdraw_all_suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package testutil
package distribution

import (
"fmt"
Expand Down
Loading