Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: deposit to validator rewards pool #14322

Merged
merged 19 commits into from
Dec 20, 2022
Merged

feat!: deposit to validator rewards pool #14322

merged 19 commits into from
Dec 20, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Replaces #14147
Credit @zmanian

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:x/distribution distribution module related labels Dec 15, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 15, 2022
View reviewed changes
x/distribution/types/msg.go
// GetSigners returns the signer addresses that are expected to sign the result
// of GetSignBytes, which is the authority.
func (msg MsgDepositValidatorRewardsPool) GetSigners() []sdk.AccAddress {
authority, _ := sdk.AccAddressFromBech32(msg.Authority)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@alexanderbez alexanderbez marked this pull request as ready for review December 15, 2022 18:46
@alexanderbez alexanderbez requested a review from a team as a code owner December 15, 2022 18:46
@alexanderbez alexanderbez enabled auto-merge (squash) December 15, 2022 20:31
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

36.5% 36.5% Coverage
0.0% 0.0% Duplication

julienrbrt
julienrbrt approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tests/integration/distribution/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 11f1e8d into main Dec 20, 2022
@alexanderbez alexanderbez deleted the bez/deposit_to_validator_rewards_pool branch December 20, 2022 15:49
@zmanian zmanian mentioned this pull request Feb 14, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp Awaiting requested review from atheeshp

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees
No one assigned
Labels
C:CLI C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbez @julienrbrt