Add DepositValidatorRewardsPool #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // GetSigners returns the signer addresses that are expected to sign the result | ||
| // of GetSignBytes, which is the authority. | ||
| func (msg MsgDepositValidatorRewardsPool) GetSigners() []sdk.AccAddress { | ||
| authority, _ := sdk.AccAddressFromBech32(msg.Authority) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
* move distribution cli tests to e2e tests * wip: add cli tests * wip: remove duplicate helpers.go file * fix something Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com>
## Description Closes: cosmos#13691 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
* use gateway fork * remove everywhere and go mod tidy all * updates Co-authored-by: Julien Robert <julien@rbrt.fr>
## Description Closes: cosmos#13444 This PR fixes the x/evidence api query which is not decoding the evidence hash properly because of its type ([]byte). We fix it with the following steps: 1. Adds a new proto field `hash` of type `string` 2. Make the old `evidence_hash` field deprecated 3. Updates query handler --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
### Description Closes: cosmos#13083 cosmos#11402 cosmos#10678 cosmos#12358 cosmos#10776 cosmos#12934 ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
* chore: use tagged rosetta version * add unit test in CI, bump tm and update changelog * update rosetta data * update action
….0 in /tools/rosetta (cosmos#13769) * build(deps): Bump github.com/btcsuite/btcd/btcec/v2 in /tools/rosetta Bumps [github.com/btcsuite/btcd/btcec/v2](https://github.com/btcsuite/btcd) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/btcsuite/btcd/releases) - [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES) - [Commits](btcsuite/btcd@btcec/v2.2.1...btcec/v2.3.0) --- updated-dependencies: - dependency-name: github.com/btcsuite/btcd/btcec/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.2.1 to 2.3.0 in /tools/rosetta for all modules Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…, `v{Consensus}` (cosmos#13772)
* chore: rename migrations from v42, v43 to v1, v2
* group migration should be in cosmos#13742
* updates
* Default GRPC and REST endpoints to localhost. Add documentation on recommended ways to expose it. Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr>
) Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](tailwindlabs/tailwindcss@v3.2.1...v3.2.2) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
* add legacy_amino_name * make-proto-gen * remove useless omitempty * add annotations * Add proto annotations * Add more annotations * update cosmos-proto * Add message scalar? * Add comments * Fix comment * lint proto files * proto-gen * go mod tidy * Add multisig encoding * Add field name * Format proto * proto-gen * Update proto/cosmos/msg/v1/msg.proto Co-authored-by: Aaron Craelius <aaron@regen.network> * Add dont_omitempty whenever we have nullable=false * proto-gen * Remove problematic annotations * put legacy_amino in subpackage * proto-gen * Fixes * legacy_amino.v1 * add non-working proto * Generate in separate package * Remove `cosmos.msg` prefix * make proto-gen * remove v1 too * make proto-format * Add field option * format * proto-gen * Use underscores * update legacy_amino -> amino * update to `key_field` * make proto-format * make proto-gen Co-authored-by: Aaron Craelius <aaron@regen.network>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 55.40% 55.48% +0.08%
==========================================
Files 648 655 +7
Lines 55829 56269 +440
==========================================
+ Hits 30930 31219 +289
- Misses 22380 22500 +120
- Partials 2519 2550 +31
|
* add: rosetta-cli to rosetta-ci image * update: rosetta readme * doc: rosetta readme * update: rosetta-cli v0.10.0 * Update contrib/rosetta/README.md Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Julien Robert <julien@rbrt.fr>
…osmos#13746) * feat!: integrate autocli and reflection services with simapp legacy * rename alias * update UPGRADING.md Co-authored-by: Julien Robert <julien@rbrt.fr>
* Move snapshotstore under store * add changelog entry * errors store * remove dep on sdk/types/errors * clean up * fix var * undo some changes, clean up fmt.Errorf usage * remove pkg/errors
…sit_to_validator_rewards_pool
github-actions
bot
added
C:Simulations
C:x/slashing
C:x/staking
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/crisis
C:x/evidence
C:x/feegrant
C:x/genutil
C:x/gov
C:x/group
C:x/mint
C:x/nft
C:x/params
C:x/upgrade
C:Cosmovisor
C:Rosetta
C:Keys
Type: Build
Type: CI
Type: ADR
C:Store
C:orm
labels
|
Implemented in cosmos#14322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: