style: comment not-yet-used fields for linter, x/circuit #15750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would often just delete these, but there was an existing TODO commment to restore those, so follow that existing style and just comment out the fields for now.
|
Given it will be erased at #14521, do you think it makes sense to fix those linting issues? |
|
Maybe not, but I would really like to get the linter fully passing. @tac0turtle how soon do you think x/circuit will be merged? |
julienrbrt
approved these changes
Apr 7, 2023
alexanderbez
reviewed
Apr 8, 2023
| addrs []sdk.AccAddress | ||
| storeKey *storetypes.KVStoreKey | ||
| sdkCtx sdk.Context | ||
| // TODO: uncomment these after implementing. |
There was a problem hiding this comment.
nit: TODO's should have referenced issues to them 🐒
There was a problem hiding this comment.
my pr that is waiting for review undoes this. dont think we need an issue for this
tac0turtle
approved these changes
Apr 10, 2023
tac0turtle
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would often just delete these, but there was an existing TODO commment to restore those, so follow that existing style and just comment out the fields for now.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change