Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: comment not-yet-used fields for linter, x/circuit #15750

Merged
merged 2 commits into from
Apr 10, 2023
Merged

style: comment not-yet-used fields for linter, x/circuit #15750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed200b3
style: comment not-yet-used fields for linter
mark-rushakoff Apr 7, 2023
177af67
Merge branch 'main' into mr/lint-circuit
tac0turtle Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions x/circuit/keeper/test_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
package keeper

import (
"context"
"testing"

storetypes "cosmossdk.io/store/types"
sdk "github.com/cosmos/cosmos-sdk/types"
)

type baseFixture struct {
t *testing.T
err error
ctx context.Context

// k Keeper //TODO uncomment this after implementing
addrs []sdk.AccAddress
storeKey *storetypes.KVStoreKey
sdkCtx sdk.Context
// TODO: uncomment these after implementing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: TODO's should have referenced issues to them 🐒

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my pr that is waiting for review undoes this. dont think we need an issue for this

// ctx context.Context

// k Keeper
// addrs []sdk.AccAddress
// storeKey *storetypes.KVStoreKey
// sdkCtx sdk.Context
}

func initFixture(t *testing.T) *baseFixture {
Expand Down