R4R: Prompt user for confirmation when deleting ledger and offline keys #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2923 +/- ##
===========================================
- Coverage 56.29% 56.23% -0.06%
===========================================
Files 120 120
Lines 8411 8400 -11
===========================================
- Hits 4735 4724 -11
Misses 3354 3354
Partials 322 322 |
alessio
changed the title
alexanderbez
approved these changes
Nov 28, 2018
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| buf := client.BufferStdin() | ||
| if info.GetType() == keys.TypeLedger || info.GetType() == keys.TypeOffline { | ||
| if !viper.GetBool(flagYes) { |
alessio
force-pushed
the
alessio/2921-delete-ledger-keys
branch
from
85a4917
to
2cc3b8f
Compare
cwgoes
approved these changes
Nov 28, 2018
|
CI failure is unrelated, once fixed on develop this LGTM. |
alessio
force-pushed
the
alessio/2921-delete-ledger-keys
branch
from
2cc3b8f
to
4898f1b
Compare
added 5 commits
November 29, 2018 15:38
Add -y flag to skip confirmation. Also keybase should not handle confirmation input.
alessio
force-pushed
the
alessio/2921-delete-ledger-keys
branch
from
4898f1b
to
4a5b52a
Compare
added 2 commits
November 29, 2018 16:03
alessio
changed the title
alessio
changed the title
cwgoes
approved these changes
Nov 29, 2018
4 tasks
5 tasks
mircea-c
pushed a commit
that referenced
this pull request
Dec 4, 2018
… offline keys * Force password to 'yes' when deleting ledger-offline keys * Improve UX, better docs on removing offline/ledger keys * Ask for confirmation on offline/ledger keys deletion
chengwenxi
added a commit
to chengwenxi/irishub
that referenced
this pull request
Dec 19, 2018
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
* fix!: check v1 and v1beta1 MsgVote in VoteSpamDecorator cosmos/gaia#2912 introuced the VoteSpamDecorator. The implementation was not complete and only v1beta1 gov types were handled. The CLI supports v1 gov types so the validation was not sufficient. This commit expands the antehandler validation to allow correct processing of both v1 and v1beta1 messages. * appease linter * test: stop app from failing non-determinism test on gov vote * ante: handle edgecase with 0 minStakedTokens * appease linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2921
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: