-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: add --force to keys delete for unattended execution #2965
Conversation
Skip password check when --force is on and delete keys unconditionally. Closes: #2961
Codecov Report
@@ Coverage Diff @@
## develop #2965 +/- ##
===========================================
+ Coverage 56.26% 56.31% +0.04%
===========================================
Files 120 120
Lines 8406 8406
===========================================
+ Hits 4730 4734 +4
+ Misses 3354 3350 -4
Partials 322 322 |
This PR looks good (does what it says), but is this a behavior we want to enable? Was there a discussion around this somewhere? |
The user needs to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testedACK ☕️
@jackzampolin FTR this PR sprang from #2923 (comment) |
I think this functionality is just fine ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK
* add --force to keys delete for unattended execution Skip password check when --force is on and delete keys unconditionally. Closes: #2961 * Forcibly cleanup keys on fixtures initialization
* bump golang.org/x/crypto to v0.17.0 * bump golang.org/x/crypto to v0.20
Skip passphrase check when --force is on and delete keys unconditionally.
Closes: #2961
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: