Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: add --force to keys delete for unattended execution #2965

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 30, 2018

Skip passphrase check when --force is on and delete keys unconditionally.

Closes: #2961

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Skip password check when --force is on and delete
keys unconditionally.

Closes: #2961
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #2965 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2965      +/-   ##
===========================================
+ Coverage    56.26%   56.31%   +0.04%     
===========================================
  Files          120      120              
  Lines         8406     8406              
===========================================
+ Hits          4730     4734       +4     
+ Misses        3354     3350       -4     
  Partials       322      322

@jackzampolin
Copy link
Member

This PR looks good (does what it says), but is this a behavior we want to enable? Was there a discussion around this somewhere?

@alessio
Copy link
Contributor Author

alessio commented Nov 30, 2018

The user needs to add --force to the command line. I think it is safe to assume that if you do that, you know what you are doing.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK ☕️

@alessio
Copy link
Contributor Author

alessio commented Nov 30, 2018

@jackzampolin FTR this PR sprang from #2923 (comment)

@alexanderbez
Copy link
Contributor

I think this functionality is just fine (rm -rf 😝 )

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 956c222 into develop Nov 30, 2018
@cwgoes cwgoes deleted the alessio/2961-gaiacli-delete-force branch November 30, 2018 20:36
mircea-c pushed a commit that referenced this pull request Dec 5, 2018
* add --force to keys delete for unattended execution

Skip password check when --force is on and delete
keys unconditionally.

Closes: #2961

* Forcibly cleanup keys on fixtures initialization
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
* bump golang.org/x/crypto to v0.17.0

* bump golang.org/x/crypto to v0.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants