R4R: Add shorthand flag to address output on gaiacli keys show and update docs #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2987 +/- ##
========================================
Coverage 55.53% 55.53%
========================================
Files 120 120
Lines 8494 8494
========================================
Hits 4717 4717
Misses 3455 3455
Partials 322 322 |
|
Hmmm, is this completely necessary? |
|
@alexanderbez it allows users to type |
|
Ok, cool. We don't have a large surface area for shorthand usage because of our ample list of CLI flags, but I think this makes sense. |
fedekunze
reviewed
Dec 3, 2018
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
|
I just need a couple of approvals here! |
cwgoes
suggested changes
Dec 4, 2018
|
Completely missed that one @cwgoes. Fixed and R4M again. |
mircea-c
pushed a commit
that referenced
this pull request
Dec 5, 2018
…show and update docs * Add shorthand flag to address output on gaiacli keys show * Update docs and add PENDING * Update client/keys/show.go Co-Authored-By: jackzampolin <jack.zampolin@gmail.com> * pk -> p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.