Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add shorthand flag to address output on gaiacli keys show and update docs #2987

Merged
merged 5 commits into from
Dec 4, 2018
Merged

R4R: Add shorthand flag to address output on gaiacli keys show and update docs #2987

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0a6293
Add shorthand flag to address output on gaiacli keys show
jackzampolin Dec 3, 2018
953a9ad
Update docs and add PENDING
jackzampolin Dec 3, 2018
11c973f
Update client/keys/show.go
fedekunze Dec 3, 2018
998c202
pk -> p
jackzampolin Dec 4, 2018
b64c095
Merge branch 'develop' into jack/add-address-flag
jackzampolin Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ BREAKING CHANGES

* Gaia CLI (`gaiacli`)
* [cli] [\#2595](https://github.com/cosmos/cosmos-sdk/issues/2595) Remove `keys new` in favor of `keys add` incorporating existing functionality with addition of key recovery functionality.
* [cli] [\#2987](https://github.com/cosmos/cosmos-sdk/pull/2987) Add shorthand `-a` to `gaiacli keys show` and update docs

* Gaia
- [#128](https://github.com/tendermint/devops/issues/128) Updated CircleCI job to trigger website build on every push to master/develop.
Expand Down Expand Up @@ -39,7 +40,7 @@ IMPROVEMENTS

* SDK
- \#1277 Complete bank module specification

* Tendermint


Expand Down
5 changes: 3 additions & 2 deletions client/keys/show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ package keys

import (
"fmt"
"net/http"

"github.com/cosmos/cosmos-sdk/crypto/keys"
"github.com/tendermint/tendermint/crypto"
"net/http"

"github.com/cosmos/cosmos-sdk/crypto/keys/keyerror"
sdk "github.com/cosmos/cosmos-sdk/types"
Expand Down Expand Up @@ -50,7 +51,7 @@ func showKeysCmd() *cobra.Command {
}

cmd.Flags().String(FlagBechPrefix, "acc", "The Bech32 prefix encoding for a key (acc|val|cons)")
cmd.Flags().Bool(FlagAddress, false, "output the address only (overrides --output)")
cmd.Flags().BoolP(FlagAddress, "a", false, "output the address only (overrides --output)")
cmd.Flags().Bool(FlagPublicKey, false, "output the public key only (overrides --output)")
jackzampolin marked this conversation as resolved.
Show resolved Hide resolved
cmd.Flags().Uint(flagMultiSigThreshold, 1, "K out of N required signatures")

Expand Down
2 changes: 1 addition & 1 deletion docs/gaia/deploy-testnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ gaiacli keys add validator
# Add that key into the genesis.app_state.accounts array in the genesis file
# NOTE: this command lets you set the number of coins. Make sure this account has some coins
# with the genesis.app_state.stake.params.bond_denom denom, the default is STAKE
gaiad add-genesis-account $(gaiacli keys show validator -o json | jq -r ".address") 1000STAKE,1000validatorToken
gaiad add-genesis-account $(gaiacli keys show validator -a) 1000STAKE,1000validatorToken

# Generate the transaction that creates your validator
gaiad gentx --name validator
Expand Down