Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auxiliary Functionality for Genesis Accounts #5042

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 12, 2019

Auxiliary type(s) and function(s) that used to exist in x/genaccounts that are needed for apps to define and use their own genesis accounts.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #5042 into master will increase coverage by 0.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #5042      +/-   ##
==========================================
+ Coverage   54.95%   55.01%   +0.05%     
==========================================
  Files         290      291       +1     
  Lines       17805    17819      +14     
==========================================
+ Hits         9785     9803      +18     
+ Misses       7314     7309       -5     
- Partials      706      707       +1

@alexanderbez alexanderbez merged commit 1028283 into master Sep 13, 2019
@alexanderbez alexanderbez deleted the bez/gen-acc-aux branch September 13, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants