Genesis Account Command + Types

[fedekunze]

• Remove usage of deprecated x/genaccounts module
• Port/adjust over add genesis account command

Ref: cosmos/cosmos-sdk#5017

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

• Reviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

[alexanderbez]

We also need to implement and register the concrete GenesisAccount type

[alexanderbez]

Blocked on cosmos/cosmos-sdk#5042

[alexanderbez]

I have no idea why we were using simapp's default genesis state...

[rhuairahrighairidh]

What’s the reason for the concrete GenesisAccount type?
As I understood, the genesis file would just contain marshalled account types (base, vesting, etc). These concrete types would implement the GenesisAccount interface (allowing them be validated) and InitGenesis would just load them straight into auth’s keeper.

[alexanderbez]

@rhuairahrighairidh great question! My initial intention and idea was that we could avoid too many layers of abstraction and simply deal with a single concrete type and also avoid migration headaches. After experimenting with adding genesis accounts, exporting and importing, I've found this to be futile. So we can deal with the core types defined in the SDK for Gaia. Other apps may possibly do the same or define their own...

This also means we'll have to modify the v0.38 migration process for accounts by creating the appropriate concrete type.

/cc @fedekunze

[alexanderbez]

testedACK

[codecov-io]

Codecov Report

Merging #122 into master will decrease coverage by 0.2%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   66.32%   66.12%   -0.21%     
==========================================
  Files           4        5       +1     
  Lines         490      493       +3     
==========================================
+ Hits          325      326       +1     
- Misses        134      136       +2     
  Partials       31       31