Dang/add port id into msg register interchain account response #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNaD13
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 177 177
Lines 12420 12421 +1
=======================================
+ Hits 9763 9764 +1
Misses 2231 2231
Partials 426 426
|
damiannolan
reviewed
Feb 24, 2023
proto/ibc/applications/interchain_accounts/controller/v1/tx.proto
Outdated
Show resolved
Hide resolved
GNaD13
requested review from
charleenfei,
chatton and
tmsdkeys
as code owners
Hi sir @crodriguezvega , Thanks for your reviewed, I've updated it |
…MsgRegisterInterchainAccountResponse
crodriguezvega
approved these changes
Feb 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
(cherry picked from commit ae27157)
crodriguezvega
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add generated portID to message MsgRegisterInterchainAccountResponse
closes: #2724
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.