Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dang/add port id into msg register interchain account response #3204

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Dang/add port id into msg register interchain account response #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69d45c7
gen proto
GNaD13 Feb 24, 2023
1579647
add portID to msg response
GNaD13 Feb 24, 2023
73c4fa4
format
GNaD13 Feb 26, 2023
67125ea
add portID to docs
GNaD13 Feb 28, 2023
07514be
Merge remote-tracking branch 'origin/main' into dang/Add-portID-into-…
GNaD13 Feb 28, 2023
d58841a
nit
GNaD13 Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/apps/interchain-accounts/messages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ If the `Version` string is omitted, the controller submodule will construct a de
```go
type MsgRegisterInterchainAccountResponse struct {
ChannelID string
PortId string
}
```

The `ChannelID` is returned in the message response.
The `ChannelID` and `PortID` are returned in the message response.

## `MsgSendTx`

Expand Down
1 change: 1 addition & 0 deletions modules/apps/27-interchain-accounts/controller/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ func (s msgServer) RegisterInterchainAccount(goCtx context.Context, msg *types.M

return &types.MsgRegisterInterchainAccountResponse{
ChannelId: channelID,
PortId: portID,
}, nil
}

Expand Down
122 changes: 87 additions & 35 deletions modules/apps/27-interchain-accounts/controller/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/ibc/applications/interchain_accounts/controller/v1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ message MsgRegisterInterchainAccount {
// MsgRegisterInterchainAccountResponse defines the response for Msg/RegisterAccount
message MsgRegisterInterchainAccountResponse {
string channel_id = 1 [(gogoproto.moretags) = "yaml:\"channel_id\""];
string port_id = 2 [(gogoproto.moretags) = "yaml:\"port_id\""];
}

// MsgSendTx defines the payload for Msg/SendTx
Expand Down