chore: address vanity nits in 08-wasm (code structure, godocs) #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
charleenfei,
chatton,
DimitrisJim,
srdtrk and
crodriguezvega
as code owners
DimitrisJim
approved these changes
Dec 5, 2023
damiannolan
commented
Dec 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
* chore: restructure mock_engine.go * chore: consolidate sdk.Msg codec registration * chore: adding godoc to WasmConfig * chore: move state storage code to store.go, rm ambiguous wasm.go and wasm_test.go files * chore: add more meat to mock engine godoc * chore: update storeAdapter godoc to use wasmvmtypes.KVStore * lint: yes * Update modules/light-clients/08-wasm/testing/mock_engine.go (cherry picked from commit cb74fd1) # Conflicts: # modules/light-clients/08-wasm/types/store.go # modules/light-clients/08-wasm/types/wasm.go # modules/light-clients/08-wasm/types/wasm_test.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
* chore: restructure mock_engine.go * chore: consolidate sdk.Msg codec registration * chore: adding godoc to WasmConfig * chore: move state storage code to store.go, rm ambiguous wasm.go and wasm_test.go files * chore: add more meat to mock engine godoc * chore: update storeAdapter godoc to use wasmvmtypes.KVStore * lint: yes * Update modules/light-clients/08-wasm/testing/mock_engine.go (cherry picked from commit cb74fd1)
damiannolan
added a commit
that referenced
this pull request
Dec 6, 2023
#5322) * chore: restructure mock_engine.go * chore: consolidate sdk.Msg codec registration * chore: adding godoc to WasmConfig * chore: move state storage code to store.go, rm ambiguous wasm.go and wasm_test.go files * chore: add more meat to mock engine godoc * chore: update storeAdapter godoc to use wasmvmtypes.KVStore * lint: yes * Update modules/light-clients/08-wasm/testing/mock_engine.go (cherry picked from commit cb74fd1) Co-authored-by: Damian Nolan <damiannolan@gmail.com>
crodriguezvega
pushed a commit
that referenced
this pull request
Dec 6, 2023
…ort #5320) (#5321) * chore: address vanity nits in 08-wasm (code structure, godocs) (#5320) * chore: restructure mock_engine.go * chore: consolidate sdk.Msg codec registration * chore: adding godoc to WasmConfig * chore: move state storage code to store.go, rm ambiguous wasm.go and wasm_test.go files * chore: add more meat to mock engine godoc * chore: update storeAdapter godoc to use wasmvmtypes.KVStore * lint: yes * Update modules/light-clients/08-wasm/testing/mock_engine.go (cherry picked from commit cb74fd1) # Conflicts: # modules/light-clients/08-wasm/types/store.go # modules/light-clients/08-wasm/types/wasm.go # modules/light-clients/08-wasm/types/wasm_test.go * resolve conflicts in backport --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MockEnginestruct def further up inmock_engine.gofile for better readability/claritysdk.Msgcodec registration to leverage varargs argumentWasmConfig,Storewrapper)store.go, delete ambiguouswasm.goandwasm_test.gofiles.I think there are more improvements that could be made to help structure the code and package layout more optimally but we can follow up on them in future.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.