chore: address vanity nits in 08-wasm (code structure, godocs) (backport #5320) #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* chore: restructure mock_engine.go * chore: consolidate sdk.Msg codec registration * chore: adding godoc to WasmConfig * chore: move state storage code to store.go, rm ambiguous wasm.go and wasm_test.go files * chore: add more meat to mock engine godoc * chore: update storeAdapter godoc to use wasmvmtypes.KVStore * lint: yes * Update modules/light-clients/08-wasm/testing/mock_engine.go (cherry picked from commit cb74fd1)
mergify
bot
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton,
DimitrisJim and
srdtrk
as code owners
damiannolan
approved these changes
Dec 6, 2023
DimitrisJim
approved these changes
Dec 6, 2023
damiannolan
merged commit 9c1428b
into
08-wasm/release/v0.1.x+ibc-go-v8.0.x-wasmvm-v1.5.x
21 checks passed
damiannolan
deleted the
mergify/bp/08-wasm/release/v0.1.x+ibc-go-v8.0.x-wasmvm-v1.5.x/pr-5320
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #5320 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com