Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix wrong comment #5828

Merged
merged 3 commits into from
Feb 12, 2024
Merged

chore: fix wrong comment #5828

merged 3 commits into from
Feb 12, 2024

Conversation

zoereco
Copy link
Contributor

@zoereco zoereco commented Feb 11, 2024

Description

froce comments to start with exported element (https://tip.golang.org/doc/comment)

Commit Message / Changelog Entry

chore: fix comments so they start with exported element

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. Thank you, @zoereco!

@colin-axner colin-axner enabled auto-merge (squash) February 12, 2024 16:12
@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (1c0c756) 81.59% compared to head (4a4a7fd) 81.48%.
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5828      +/-   ##
==========================================
- Coverage   81.59%   81.48%   -0.12%     
==========================================
  Files         199      199              
  Lines       15167    12090    -3077     
==========================================
- Hits        12375     9851    -2524     
+ Misses       2326     1774     -552     
+ Partials      466      465       -1     
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 84.15% <100.00%> (+0.45%) ⬆️
...les/apps/27-interchain-accounts/host/ibc_module.go 90.56% <100.00%> (-1.37%) ⬇️
...ules/apps/27-interchain-accounts/types/metadata.go 81.01% <100.00%> (+1.21%) ⬆️
modules/apps/29-fee/keeper/escrow.go 89.88% <ø> (-2.88%) ⬇️
modules/apps/29-fee/types/keys.go 96.72% <ø> (-0.43%) ⬇️
modules/apps/29-fee/types/msgs.go 100.00% <ø> (ø)
modules/apps/transfer/types/codec.go 100.00% <ø> (+13.79%) ⬆️
modules/core/02-client/keeper/keeper.go 83.54% <100.00%> (+0.51%) ⬆️
modules/core/03-connection/keeper/verify.go 83.63% <100.00%> (+3.27%) ⬆️
modules/core/03-connection/types/connection.go 100.00% <ø> (+10.16%) ⬆️
... and 7 more

... and 154 files with indirect coverage changes

@colin-axner colin-axner merged commit e555a17 into cosmos:main Feb 12, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants