Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix wrong comment #5828

Merged
merged 3 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/testsuite/grpc_query.go
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ func (s *E2ETestSuite) QueryGranterGrants(ctx context.Context, chain ibc.Chain,
return grants.Grants, nil
}

// QueryBalances returns all the balances on the given chain for the provided address.
// QueryAllBalances returns all the balances on the given chain for the provided address.
func (s *E2ETestSuite) QueryAllBalances(ctx context.Context, chain ibc.Chain, address string, resolveDenom bool) (sdk.Coins, error) {
queryClient := s.GetChainGRCPClients(chain).BankQueryClient
res, err := queryClient.AllBalances(ctx, &banktypes.QueryAllBalancesRequest{
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/27-interchain-accounts/host/ibc_module.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (IBCModule) OnChanOpenAck(
return errorsmod.Wrap(icatypes.ErrInvalidChannelFlow, "channel handshake must be initiated by controller chain")
}

// OnChanOpenAck implements the IBCModule interface
// OnChanOpenConfirm implements the IBCModule interface
func (im IBCModule) OnChanOpenConfirm(
ctx sdk.Context,
portID,
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/29-fee/keeper/escrow.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (k Keeper) distributePacketFeeOnAcknowledgement(ctx sdk.Context, refundAddr
k.distributeFee(ctx, refundAddr, refundAddr, refundCoins)
}

// DistributePacketsFeesOnTimeout pays all the timeout fees for a given packetID while refunding the acknowledgement & receive fees to the refund account.
// DistributePacketFeesOnTimeout pays all the timeout fees for a given packetID while refunding the acknowledgement & receive fees to the refund account.
func (k Keeper) DistributePacketFeesOnTimeout(ctx sdk.Context, timeoutRelayer sdk.AccAddress, packetFees []types.PacketFee, packetID channeltypes.PacketId) {
// cache context before trying to distribute fees
// if the escrow account has insufficient balance then we want to avoid partially distributing fees
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/29-fee/types/keys.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const (

Version = "ics29-1"

// FeeEnabledPrefix is the key prefix for storing fee enabled flag
// FeeEnabledKeyPrefix is the key prefix for storing fee enabled flag
FeeEnabledKeyPrefix = "feeEnabled"

// PayeeKeyPrefix is the key prefix for the fee payee address stored in state
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/29-fee/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (msg MsgPayPacketFee) ValidateBasic() error {
return msg.Fee.Validate()
}

// NewMsgPayPacketAsync creates a new instance of MsgPayPacketFee
// NewMsgPayPacketFeeAsync creates a new instance of MsgPayPacketFeeAsync
func NewMsgPayPacketFeeAsync(packetID channeltypes.PacketId, packetFee PacketFee) *MsgPayPacketFeeAsync {
return &MsgPayPacketFeeAsync{
PacketId: packetID,
Expand Down
2 changes: 1 addition & 1 deletion modules/light-clients/08-wasm/testing/mock_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (m *MockWasmEngine) StoreCode(code wasmvm.WasmCode) (wasmvm.Checksum, error
return m.StoreCodeFn(code)
}

// StoreCode implements the WasmEngine interface.
// StoreCodeUnchecked implements the WasmEngine interface.
func (m *MockWasmEngine) StoreCodeUnchecked(code wasmvm.WasmCode) (wasmvm.Checksum, error) {
if m.StoreCodeUncheckedFn == nil {
panic(errors.New("mock engine is not properly initialized: StoreCodeUncheckedFn is nil"))
Expand Down
2 changes: 1 addition & 1 deletion modules/light-clients/08-wasm/types/contract_api.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ type VerifyUpgradeAndUpdateStateMsg struct {
ProofUpgradeConsensusState []byte `json:"proof_upgrade_consensus_state"`
}

// MigrateClientStore is a sudoMsg sent to the contract to verify a given substitute client and update to its state.
// MigrateClientStoreMsg is a sudoMsg sent to the contract to verify a given substitute client and update to its state.
type MigrateClientStoreMsg struct{}

// ContractResult is a type constraint that defines the expected results that can be returned by a contract call/query.
Expand Down
2 changes: 1 addition & 1 deletion modules/light-clients/08-wasm/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var (
_ sdk.HasValidateBasic = (*MsgRemoveChecksum)(nil)
)

// MsgStoreCode creates a new MsgStoreCode instance
// NewMsgStoreCode creates a new MsgStoreCode instance
func NewMsgStoreCode(signer string, code []byte) *MsgStoreCode {
return &MsgStoreCode{
Signer: signer,
Expand Down
2 changes: 1 addition & 1 deletion testing/solomachine.go
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ func (solo *Solomachine) TimeoutPacket(chain *TestChain, packet channeltypes.Pac
require.NotNil(solo.t, res)
}

// TimeoutPacket creates a channel closed and unreceived packet proof and broadcasts a MsgTimeoutOnClose.
// TimeoutPacketOnClose creates a channel closed and unreceived packet proof and broadcasts a MsgTimeoutOnClose.
func (solo *Solomachine) TimeoutPacketOnClose(chain *TestChain, packet channeltypes.Packet, channelID string) {
closedProof := solo.GenerateChanClosedProof(transfertypes.PortID, transfertypes.Version, channelID)
unreceivedProof := solo.GenerateReceiptAbsenceProof(packet)
Expand Down
Loading