Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database)!: remove cloudwatchLogsExportConfiguration #1835

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Aug 7, 2023

Description of your changes

subject database.RDSInstance:

  • Breaking API change: remove field cloudwatchLogsExportConfiguration (CloudwatchLogsExportConfiguration is a specific parameter for the ModifyDBInstance call, that overlapped with EnableCloudwatchLogsExports, which is used in CreateDBInstance)
  • add status field atProvider.enabledCloudwatchLogsExports
  • add logic to isUpToDate and Update/GenerateModifyDBInstanceInput (as also used in DocDB.DBCluster controller for the same parameters)
  • remove EnableCloudwatchLogsExports lateinit (to allow user to disable all again with empty string; is AWS default)
  • update tests

(Fixes #1795 regarding my comment there)

Breaking change ToDos/notes for users:

  • claims using cloudwatchLogsExportConfiguration need to instead use enableCloudwatchLogsExports

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it makes sense to not have redundant spec properties. Thank you very much for your contribution @wotolom!

@MisterMX MisterMX merged commit c72a79c into crossplane-contrib:master Aug 9, 2023
8 checks passed
wotolom pushed a commit to wotolom/provider-aws that referenced this pull request Aug 18, 2023
…ib#1835

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
@wotolom wotolom deleted the rdsinstance-CloudwatchLogsExportConfiguration-fix branch August 18, 2023 11:26
dee0 pushed a commit to dee0sap/provider-aws that referenced this pull request Aug 28, 2023
…ib#1835

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
threadproc pushed a commit to swisscom/provider-aws that referenced this pull request Sep 1, 2023
…ib#1835

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
teeverr pushed a commit to swisscom/provider-aws that referenced this pull request Oct 13, 2023
…ib#1835

Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <charel.baum-extern@deutschebahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot modify RDS instance: api error InvalidParameterCombination: No modifications were requested
2 participants