Fixes and Tweaks with Uptest related targets #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
changed the title
turkenh
changed the title
turkenh
force-pushed
the
fix-local-dev
branch
from
3369eb7
to
89ddaba
Compare
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
fix-local-dev
branch
from
89ddaba
to
4073549
Compare
|
/test-examples="examples/codecommit/approvalruletemplateassociation.yaml" |
|
/test-examples="examples/codecommit/approvalruletemplateassociation.yaml" |
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
fix-local-dev
branch
from
1488b2c
to
3d06eda
Compare
|
/test-examples="examples/codecommit/approvalruletemplateassociation.yaml" |
This was referenced Nov 14, 2022
Merged
ulucinar
approved these changes
Nov 14, 2022
turkenh
added a commit
to turkenh/upbound-provider-gcp
that referenced
this pull request
Nov 21, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
added a commit
to turkenh/upbound-provider-azure
that referenced
this pull request
Nov 21, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
added a commit
to turkenh/upbound-provider-gcp
that referenced
this pull request
Nov 21, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
added a commit
to turkenh/upbound-provider-azure
that referenced
this pull request
Nov 21, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes couple of issues with local dev flow with uptest:
Testas default conditionmake uptestcould be called when provider is running externally withmake run(i.e. previous workflow withmake uptest-local)I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Also