Reuse Uptest workflow and standardize Makefile targets #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
|
Converting to draft for now since I need to incorporate changes here: crossplane-contrib/provider-upjet-aws#143 |
This was referenced Nov 17, 2022
This is done. |
ulucinar
reviewed
Nov 21, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
reuse-uptest-workflow
branch
from
63d42af
to
5042a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Consumes reusable workflows introduced in upbound/official-providers-ci#39
Also, standardize Makefile targets and cleans up old script.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Validated workflow changes with crossplane-contrib/provider-upjet-aws#116