Reuse Uptest workflow and standardize Makefile targets #116
Conversation
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
|
|
||
| echo "Running setup.sh" | ||
| echo "Creating cloud credential secret..." | ||
| ${KUBECTL} -n upbound-system create secret generic provider-secret --from-literal=credentials="${UPTEST_CLOUD_CREDENTIALS}" --dry-run=client -o yaml | ${KUBECTL} apply -f - |
There was a problem hiding this comment.
Is the set of expected environment variables to run the e2e and uptest targets documented somewhere?
There was a problem hiding this comment.
e2e is expected to run with CI and uptest is not different than the previous uptest-local target. I'll update the docs, e.g. this, accordingly.
There was a problem hiding this comment.
Just pushed a new commit adding some comments and a deprecation notice for uptest-local target.
|
|
||
| echo "Running setup.sh" | ||
| echo "Creating cloud credential secret..." | ||
| ${KUBECTL} -n upbound-system create secret generic provider-secret --from-literal=credentials="${UPTEST_CLOUD_CREDENTIALS}" --dry-run=client -o yaml | ${KUBECTL} apply -f - |
There was a problem hiding this comment.
Is there a reason we dry-run and then pipe to an apply instead of running without the --dry-run option?
There was a problem hiding this comment.
yes, if I don't include that it fails when secret exists.
kubectl create secret generic aws-secret -n upbound-system --from-file=creds=/Users/hasanturken/.aws/credentials -o yaml | kubectl apply -f -
error: failed to create secret secrets "aws-secret" already exists
error: no objects passed to apply
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
reuse-uptest-workflow
branch
from
cf20c77
to
6218917
Compare
|
@ulucinar pushed a commit and responded your comments, could you have another look? |
Description of your changes
Consumes reusable workflows introduced in upbound/official-providers-ci#39
Also, standardize Makefile targets and cleans up old script.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I'll only be able to test GitHub actions after merging this PR.