Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse uptest workflow #41

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Nov 10, 2022

Description of your changes

Consumes reusable workflows introduced in upbound/official-providers-ci#39
Also, standardize Makefile targets.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

export UPTEST_CLOUD_CREDENTIALS=$(cat gcp-sa.json)
make e2e

Validated workflow changes with crossplane-contrib/provider-upjet-aws#116

Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh marked this pull request as ready for review November 10, 2022 20:55
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on results from upbound/platform-ref-azure#23 test run

@turkenh turkenh merged commit 6208fdf into upbound:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants