feat(agent): implement Agent HTTP dynamic JFR start #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
changed the base branch from
main
to
1578-epic-two-way-agent-communications
andrewazores
changed the title
andrewazores
force-pushed
the
agent-communication
branch
from
933cbbd
to
b872724
Compare
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
andrewazores
force-pushed
the
agent-communication
branch
3 times, most recently
from
7a9555b
to
ebbe5ef
Compare
andrewazores
force-pushed
the
agent-communication
branch
from
ebbe5ef
to
87e481e
Compare
|
This PR/issue depends on: |
There was a problem hiding this comment.
Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
…FlightRecorderService
andrewazores
force-pushed
the
agent-communication
branch
from
87e481e
to
b958354
Compare
7 tasks
maxcao13
approved these changes
Aug 1, 2023
andrewazores
merged commit 18e46b6
into
cryostatio:1578-epic-two-way-agent-communications
8 checks passed
11 tasks
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
7 tasks
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Aug 27, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Sep 7, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 13, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 15, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 18, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 18, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 19, 2023
* chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * add unimplemented overrides * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version
andrewazores
added a commit
that referenced
this pull request
Sep 19, 2023
* feat(agent): implement Agent HTTP dynamic JFR start (#1566) * chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version * feat(agent): implement Agent HTTP dynamic JFR stop/delete (#1604) * feat(agent): implement Agent HTTP recording retrieval (#1607) * feat(agent): implement HTTP JFR snapshot creation (#1627) Co-authored-by: Atif Ali <56743004+aali309@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to cryostatio/cryostat-agent#162
Depends on cryostatio/cryostat-agent#165
Depends on cryostatio/cryostat-core#245
Fixes #1580
Related to #1579
Description of the change:
Refactor to extract some logic out to
-coreand use an additional abstraction on top of the JMCIFlightRecorderService. The newCryostastFlightRecorderServicesubinterface provides higher-level operation abstractions to support theAgentService/AgentConnection/AgentClientHTTP-based communications, so that existing code needs minimal changes to perform operations like dynamically starting recordings by providing arguments like event template name+type, or later the whole event template XML document (for custom event templates), rather than using the JMCIConstrainedMapmodel.How to manually test:
-coreand-agentquarkus-testto include two dependencies above and feat(api): enable dynamic JFR start cryostat-agent#165CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...- note thatquarkus-test-agent-2hasCRYOSTAT_AGENT_API_WRITES_ENABLED=true.quarkus-test-agent-2(http://localhost:9988) and verify that the recording creation succeeds