feat(agent): implement Agent HTTP recording retrieval #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-triage
|
This PR/issue depends on:
|
andrewazores
changed the base branch from
main
to
1578-epic-two-way-agent-communications
11 tasks
andrewazores
added
feat
andrewazores
force-pushed
the
agent-recording-stream
branch
from
a59f599
to
afb9785
Compare
mwangggg
approved these changes
Aug 14, 2023
andrewazores
merged commit 5b947e0
into
cryostatio:1578-epic-two-way-agent-communications
16 of 17 checks passed
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Aug 27, 2023
aali309
pushed a commit
to aali309/cryostat-legacy
that referenced
this pull request
Sep 7, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 13, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 15, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 18, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 18, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 19, 2023
andrewazores
added a commit
that referenced
this pull request
Sep 19, 2023
* feat(agent): implement Agent HTTP dynamic JFR start (#1566) * chore(svc): extract EventOptionsBuilder to -core and use new CryostatFlightRecorderService * test(smoketest): enable API writes on one agent-equipped sample app * chore(serial): extract recording descriptor to -core * chore(activerecordings): clean up an error handler * feat(agent): implement dynamic start of JFR over HTTP * bump -core version * feat(agent): implement Agent HTTP dynamic JFR stop/delete (#1604) * feat(agent): implement Agent HTTP recording retrieval (#1607) * feat(agent): implement HTTP JFR snapshot creation (#1627) Co-authored-by: Atif Ali <56743004+aali309@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainBased on #1604
Depends on cryostatio/cryostat-agent#179
Fixes #1582
Description of the change:
This replaces stubs with real implementations for pulling JFR files from Cryostat Agent instances over HTTP.
Motivation for the change:
Users can deploy their workload applications with the Cryostat Agent and dynamically start/analyze/retrieve/stop/delete recordings all over the Agent HTTP API rather than over JMX.
How to manually test: