Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch our requests pin to only exclude 2.32.0 #21996

Closed
wants to merge 4 commits into from

Conversation

jmsanders
Copy link
Contributor

Both docker-py and requests have fixes in flight. We can narrow our pin to only exclude the breaking version.

docker/docker-py#3257
psf/requests#6707 (comment)

Both docker-py and requests have fixes in flight. We can narrow our pin
to only exclude the breaking version.

docker/docker-py#3257
psf/requests#6707 (comment)
@jmsanders jmsanders self-assigned this May 21, 2024
@@ -138,7 +138,7 @@ def get_version() -> str:
"morefs[asynclocal]",
"fsspec<2024.5.0", # morefs incompatibly
"rapidfuzz",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it here at all with the pin in place in dagster-docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tests] installs docker directly

requests had a second patch release yesterday where the issue still
persists.
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear to me this needs to be anywhere other than dagster-docker given the stack trace? and maybe dagster[test]?

@jmsanders
Copy link
Contributor Author

We're just going to revert once docker publishes to pypi.

@jmsanders jmsanders closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants