Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch our requests pin to only exclude 2.32.0 #21996

Closed
wants to merge 4 commits into from
Closed

Switch our requests pin to only exclude 2.32.0 #21996

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
505720d
Switch our requests pin to only exclude 2.32.0
jmsanders May 21, 2024
52a4fc7
[NO_SKIP=True] Trigger full build
jmsanders May 21, 2024
b01d1b9
Also pin around 2.32.1
jmsanders May 21, 2024
b1357d8
[NO_SKIP=true] Trigger full build
jmsanders May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions integration_tests/test_suites/backcompat-test-suite/webserver_service/pins.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ sqlalchemy<2.0.0
# Added pendulum pin in later versions
pendulum<3

# 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
requests<2.32.0
# https://github.com/dagster-io/dagster/pull/21977
requests!=2.32.0
2 changes: 1 addition & 1 deletion python_modules/dagster/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def get_version() -> str:
"morefs[asynclocal]",
"fsspec<2024.5.0", # morefs incompatibly
"rapidfuzz",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it here at all with the pin in place in dagster-docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tests] installs docker directly

],
"mypy": ["mypy==1.8.0"],
"pyright": [
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-celery-docker/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def get_version() -> str:
f"dagster-celery{pin}",
f"dagster-graphql{pin}",
"docker",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
],
zip_safe=False,
)
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-docker/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def get_version() -> str:
f"dagster{pin}",
"docker",
"docker-image-py",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
],
zip_safe=False,
)