Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove <base /> #674

Closed
wants to merge 2 commits into from
Closed

fix: remove <base /> #674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16dd784
init
Aslemammad Apr 26, 2024
9ba4bf3
update
Aslemammad Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/waku/src/lib/plugins/vite-plugin-rsc-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ ${opts.htmlHead}
},
transformIndexHtml() {
return [
// HACK without <base>, some relative assets don't work.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what was the original problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No honestly, but what I guess was the potential solution was the fact the we made things either absolute to the project root or to the user's root.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check:

image

Now, let's try this branch:

same error

image

So, no, it's not fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check this soon!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research and might figure out the root case. I am not so sure can i open another pr to solve this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PerfectPan For sure! feel free to, i'd be happy to close this if that solves it.

// FIXME ideally, we should avoid this.
{ tag: 'base', attrs: { href: opts.basePath } },
{
tag: 'script',
attrs: { type: 'module', async: true },
Expand Down
Loading