fix: remove <base /> #674
fix: remove <base /> #674
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -75,9 +75,6 @@ ${opts.htmlHead} | |||
| }, | |||
| transformIndexHtml() { | |||
| return [ | |||
| // HACK without <base>, some relative assets don't work. | |||
There was a problem hiding this comment.
Do you know what was the original problem?
There was a problem hiding this comment.
No honestly, but what I guess was the potential solution was the fact the we made things either absolute to the project root or to the user's root.
There was a problem hiding this comment.
Let me check:
- It's introduced in breaking: no index html #289.
- cb17af5
- Going back to 7c0a6ef and remove the hack
- npm run website:prd
- open http://localhost:8080/blog/introducing-waku
Now, let's try this branch:
- git switch fix/remove-base
- npm run website:prd
- open http://localhost:8080/blog/introducing-waku
same error
So, no, it's not fixed.
There was a problem hiding this comment.
will check this soon!
There was a problem hiding this comment.
I did some research and might figure out the root case. I am not so sure can i open another pr to solve this?
There was a problem hiding this comment.
@PerfectPan For sure! feel free to, i'd be happy to close this if that solves it.
|
Superseded by #697. |
…root path (#697) Solve #649. I did some research based on #674. The root cause is that css path in html missing / so that when brower try to join the real path, it will use the current path instead of root path.  
Resolves #649