fix: non js assets path should add config.basePath to be relative to root path

[PerfectPan]

Solve #649.

I did some research based on #674. The root cause is that css path in html missing / so that when brower try to join the real path, it will use the current path instead of root path.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	May 5, 2024 2:54am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[dai-shi]

Thanks for investigating into it! It looks valid.
We use basePath instead of /. (Though, we don't have tests and changing basePath in config might not fully work, yet. Contributions are welcome.)

[PerfectPan]

Thanks for investigating into it! It looks valid. We use basePath instead of /. (Though, we don't have tests and changing basePath in config might not fully work, yet. Contributions are welcome.)

I totally ignore the basePath option lol. I have already changed the code.

For changing basePath in config, I tried and it seems not working well.

This may involve the paths of resources in HTML files, the paths of generated files, and the paths for server hosting static resources. It seems that something is not quite right with all of them.

Would you mind I open an another issue to follow this and try to add test cases and solution later?

[dai-shi]

Yeah, we have the basePath config but it's never used in cli.ts.
(I guess it would be app.use('/test/*', ...).)

Please open a new issue and maybe our first target would be SSG.

[dai-shi]

The code looks okay.

I wonder if @Aslemammad can give a review too.

[Aslemammad]

Clean & Simple! I love the catch.