Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dartpy access to getTransformFrom{Parent|Child}BodyNode() #1377

Merged

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Jul 24, 2019

For now, those Isometry transformations could only be set, but not read.

  1. Add wrapper to add get functionality.
  2. Add python unittest to verify, that it is available and returns the same Isometry3.

[Remove this line and describe this pull request. Link to relevant GitHub issues, if any.]


Before creating a pull request

  • Document new methods and classes -> Should this be done for python bindings as well? The pybind11 code does not yet seem to be documented at all.
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

For now, those Isometry transformations could only be set, but not read.

1. Add wrapper to add get functionality.
2. Add python unittest to verify, that it is available and returns the same Isometry3.
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be done for python bindings as well? The pybind11 code does not yet seem to be documented at all.

Don't worry about this because of what you pointed out. We should add documentation in the future, but it should be fine for now.

python/dartpy/dynamics/Joint.cpp Outdated Show resolved Hide resolved
python/dartpy/dynamics/Joint.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1377 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   56.97%   56.97%           
=======================================
  Files         366      366           
  Lines       27460    27460           
=======================================
  Hits        15646    15646           
  Misses      11814    11814

chhinze and others added 2 commits July 25, 2019 09:02
Co-Authored-By: Jeongseok Lee <jslee02@users.noreply.github.com>
Co-Authored-By: Jeongseok Lee <jslee02@users.noreply.github.com>
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to go.

@jslee02 jslee02 merged commit 18bfafd into dartsim:master Jul 25, 2019
@chhinze
Copy link
Contributor Author

chhinze commented Jul 25, 2019

Awesome. Thank you.

@chhinze chhinze deleted the fix/pyAccessJointParentChildTransformation branch July 25, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants