Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add joint velocity limit constraint support #1407

Merged
merged 13 commits into from
Aug 29, 2019
Merged

Add joint velocity limit constraint support #1407

merged 13 commits into from
Aug 29, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 27, 2019

This PR is to resolve #296 and https://dartsim.discourse.group/t/joint-velocities-over-the-velocity-limit/119.

This PR depends on #1406 (merged)


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 27, 2019
dart/dynamics/Joint.hpp Outdated Show resolved Hide resolved
@jslee02 jslee02 marked this pull request as ready for review August 27, 2019 05:15
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1407 into master will increase coverage by 0.03%.
The diff coverage is 76.29%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   57.28%   57.31%   +0.03%     
==========================================
  Files         366      367       +1     
  Lines       27483    27517      +34     
==========================================
+ Hits        15743    15771      +28     
- Misses      11740    11746       +6
Impacted Files Coverage Δ
dart/dynamics/Joint.hpp 66.66% <ø> (ø) ⬆️
dart/dynamics/detail/JointAspect.hpp 66.66% <ø> (ø) ⬆️
dart/constraint/ConstraintSolver.cpp 66.3% <100%> (ø) ⬆️
dart/constraint/JointLimitConstraint.hpp 100% <100%> (ø)
dart/dynamics/Joint.cpp 56.76% <57.14%> (-1.01%) ⬇️
dart/constraint/JointLimitConstraint.cpp 71.5% <76.98%> (+3.81%) ⬆️

@jslee02
Copy link
Member Author

jslee02 commented Aug 29, 2019

@mxgrey Please let me know if you have any further concerns on this PR.

@jslee02 jslee02 requested a review from mxgrey August 29, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add joint velocity limit constraint
2 participants