Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default root joint name to "rootJoint" #1406

Merged
merged 6 commits into from
Aug 28, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 27, 2019

The default root joint name was unintentionally changed in #1339, which lead to break several examples that depend on the root joint name. This PR fixes it by reverting the name back.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 27, 2019
@jslee02 jslee02 marked this pull request as ready for review August 27, 2019 05:16
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@49dd195). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1406   +/-   ##
=========================================
  Coverage          ?   57.29%           
=========================================
  Files             ?      366           
  Lines             ?    27483           
  Branches          ?        0           
=========================================
  Hits              ?    15746           
  Misses            ?    11737           
  Partials          ?        0
Impacted Files Coverage Δ
dart/utils/urdf/DartLoader.cpp 78.83% <100%> (ø)

mxgrey
mxgrey previously approved these changes Aug 27, 2019
@jslee02 jslee02 merged commit 9ea802b into master Aug 28, 2019
@jslee02 jslee02 deleted the root_joint_name branch August 28, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants