Increment body node version after it has been moved to a new skeleton #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
reviewed
Apr 20, 2020
|
Sorry, that's what I meant for the target branch to be. It's updated now. |
|
I've added a unit test that fails if this line gets removed. |
jslee02
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Looks good to me.
It seems CI tests are failing due to issues that are unrelated to this change. release-6.9 has been failing: https://dev.azure.com/dartsim/dart/_build/results?buildId=2053&view=results
Codecov Report
@@ Coverage Diff @@
## release-6.9 #1445 +/- ##
===============================================
+ Coverage 56.96% 56.99% +0.02%
===============================================
Files 366 366
Lines 27145 27146 +1
===============================================
+ Hits 15464 15472 +8
+ Misses 11681 11674 -7
|
5 tasks
7 tasks
azeey
added a commit
to gazebosim/gz-physics
that referenced
this pull request
Jun 24, 2021
…268) When a joint is created between BodyNodes in different skeletons, the child BodyNode is moved to the skeleton of the parent BodyNode. When this happens, the BodyNode version of the child needs to be incremented. This is actually fixed by dartsim/dart#1445, but we don't have that merged into our fork. So in the meantime, we call incrementVersion after moveTo is called similar to #31. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue with auto-updating collisions was found in ign-physics. This PR ports the fix into DART itself.
I will be pushing a regression test for this issue shortly.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md