Increment body node version after it has been removed from a new skeleton #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # CMakeLists.txt # package.xml
mxgrey
previously approved these changes
Aug 27, 2020
added 2 commits
August 27, 2020 08:37
# Conflicts: # unittests/regression/test_Issue1445.cpp
|
No worries. #1445 was a great hint for me to quickly fix the issue :) |
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 58.11% 58.18% +0.06%
==========================================
Files 414 414
Lines 30006 30008 +2
==========================================
+ Hits 17439 17459 +20
+ Misses 12567 12549 -18
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1445 was introduced to increment body node version after it's being added to a skeleton as a fix for the auto-updating collisions. However, this change doesn't cover the case that a body node is removed from a skeleton instead of transferring to a new skeleton. This PR is a fix for the case by incrementing the version when a body node is being removed from the skeleton.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md