Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python bindings for CollisionFilter #1465

Merged
merged 9 commits into from
May 12, 2020
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 10, 2020

This PR is created based on #1457.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone May 10, 2020
@jslee02 jslee02 mentioned this pull request May 10, 2020
5 tasks
@jslee02 jslee02 force-pushed the dartpy/collision_filter_v2 branch from fd77765 to 9d811f8 Compare May 10, 2020 18:58
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #1465 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   58.21%   58.21%   -0.01%     
==========================================
  Files         412      412              
  Lines       29911    29913       +2     
==========================================
+ Hits        17414    17415       +1     
- Misses      12497    12498       +1     
Impacted Files Coverage Δ
dart/collision/CollisionFilter.hpp 66.66% <ø> (-33.34%) ⬇️
dart/collision/CollisionFilter.cpp 64.81% <100.00%> (+0.66%) ⬆️

@jslee02 jslee02 merged commit 514a928 into master May 12, 2020
@jslee02 jslee02 deleted the dartpy/collision_filter_v2 branch May 12, 2020 06:36
@costashatz
Copy link
Contributor

@jslee02 this PR causes python bindings on my system (Xubuntu 18.04) to fail with segfault everytime I do import dartpy (I will try later today on my archlinux system to check if it makes it break there also). Any ideas what could be causing this? Is it passing the tests (I assume you have tests for executing python examples)?

@jslee02
Copy link
Member Author

jslee02 commented May 13, 2020

Did it work on your system before this PR?

Is it passing the tests (I assume you have tests for executing python examples)?

Yes: https://github.com/dartsim/dart/runs/665747409#step:4:583

@costashatz
Copy link
Contributor

Did it work on your system before this PR?

Yes and I tried again going back to a previous commit and it is working again.

Yes: https://github.com/dartsim/dart/runs/665747409#step:4:583

I am using Ubuntu 18.04, but they still pass in your CIs.

Any ideas on what I can check? I could do a debug build and see if I can find something in the trace but I doubt it.

@costashatz
Copy link
Contributor

@jslee02 in arch-linux I am getting the following when doing import dartpy:

ImportError: /usr/lib/python3.8/site-packages/dartpy.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZN4dart6python15CollisionFilterERN8pybind116moduleE

Again, if I revert to a previous commit, it is working.

@costashatz
Copy link
Contributor

@jslee02 after cleaning up the cmake build folder and re-configuring, it seems that it is working. So, I guess it was a CMake thing.. Sorry for the fuzz..

@jslee02
Copy link
Member Author

jslee02 commented May 18, 2020

Glad it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants