Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyramid shape support #1466

Merged
merged 11 commits into from
Jul 31, 2020
Merged

Add pyramid shape support #1466

merged 11 commits into from
Jul 31, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 12, 2020

This PR adds the pyramid shape that has a square base. Currently, only FCL supports the shape for collision detection. Like other primitive shapes, the pyramid shape is converted to equivalent mesh with minimal numbers of vertices and faces. Both GLUT and OSG renderer can render the pyramid shape.

The moments of inertia for the pyramid shape is not implemented in this PR.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone May 12, 2020
@jslee02 jslee02 marked this pull request as draft May 12, 2020 00:21
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1466 into master will decrease coverage by 0.14%.
The diff coverage is 5.43%.

@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   58.20%   58.06%   -0.15%     
==========================================
  Files         412      414       +2     
  Lines       29913    30004      +91     
==========================================
+ Hits        17412    17422      +10     
- Misses      12501    12582      +81     
Impacted Files Coverage Δ
dart/constraint/BoxedLcpConstraintSolver.cpp 53.00% <0.00%> (ø)
dart/dynamics/PyramidShape.hpp 0.00% <0.00%> (ø)
dart/collision/fcl/FCLCollisionDetector.cpp 84.83% <2.85%> (-4.80%) ⬇️
dart/dynamics/PyramidShape.cpp 6.25% <6.25%> (ø)
dart/utils/SkelParser.cpp 66.66% <14.28%> (-0.39%) ⬇️
dart/dynamics/Skeleton.cpp 66.33% <0.00%> (+0.16%) ⬆️
dart/collision/detail/UnorderedPairs.hpp 95.00% <0.00%> (+5.00%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review July 26, 2020 05:53
@jslee02 jslee02 merged commit 43a2d10 into master Jul 31, 2020
@jslee02 jslee02 deleted the pyramid_master branch July 31, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant