Change dbname declaration in spark.catalog.exists

[souravbaner-da]

Close #858

[github-advanced-security]

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[GeekSheikh]

@souravbaner-da -- test is failing

overwatch/src/test/scala/com/databricks/labs/overwatch/pipeline/InitializeTest.scala

Lines 39 to 53 in 5337cad

	describe("Tests for initialize database") {
	ignore ("initializeDatabase function should create both elt and consumer database") {
	import spark.implicits._
	val conf = new Config
	conf.setDatabaseNameAndLoc("overwatch_etl", "file:/src/test/resources/overwatch/spark-warehouse/overwatch_etl.db", "file:/src/test/resources/overwatch/spark-warehouse/overwatch.db")
	conf.setConsumerDatabaseNameandLoc("overwatch", "file:/src/test/resources/overwatch/spark-warehouse/overwatch.db")
	val init = new Initializer(conf)
	val database = PrivateMethod[Database]('initializeDatabase)
	init invokePrivate database()
	val databases = spark.sql("show databases").select("namespace").map(f => f.getString(0)).collect()
	assert(databases.contains("overwatch_etl"))
	assert(databases.contains("overwatch"))
	}
	}

overwatch/src/test/scala/com/databricks/labs/overwatch/pipeline/InitializeTest.scala

Lines 239 to 247 in 5337cad

	it("dataTargetIsValid function should throw exception when the current db location is different than the one present already") {
	val dataTarget = DataTarget(Some("overwatch_etl"),Some("/path/to/database"), Some("/path/prefix"), Some("overwatch"), Some("/path/to/consumer_database"))
	spark.sql("create database if not exists overwatch_etl")
	val conf = new Config
	val init = new Initializer(conf)
	val dataTargetIsValid = PrivateMethod[Boolean]('dataTargetIsValid)
	assertThrows[BadConfigException](init invokePrivate dataTargetIsValid(dataTarget))
	}

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[souravbaner-da]

Currently this issue will be on hold. As the suggested solution depend on spark version. Specifically from spark version 3.3.0 the solution is working fine and for all other version the solution is failing.
Only solution for this is to check spark version during the check of database exist and build our solution depend on the spark version.
May be look into it in future release.

For now in overwatch public doc we will mention that database name in config should not contain any special character. Corresponding PR for the documentation is
#875

[souravbaner-da]

Currently this PR is on hold. Will start working on this after we are done with below issue #858

[CLAassistant]

All committers have signed the CLA.