Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Drop support for Ember < 3.16, Node 6+8 #95

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

simonihmig
Copy link
Contributor

Using ember-cli-update to update dependencies and drop support for old versions.

@simonihmig simonihmig mentioned this pull request Nov 23, 2020
@simonihmig
Copy link
Contributor Author

Seems Travis is not enabled by default anymore for OSS projects. Added a commit that sets up Github Actions. Although that will only get triggered once the config is in master!

@simonihmig
Copy link
Contributor Author

Hey @davewasmer, could you have a look at this (and #96) please?

@davewasmer
Copy link
Owner

@simonihmig Unfortunately I'm no longer supporting any production Ember apps at the moment, so I'm not comfortable doing the code review / planning / maintenance here. I know @Exelord had taken over much of the work on this addon - perhaps they could chime in?

Copy link
Collaborator

@Exelord Exelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Though, before a release the new CI setup needs to be verified.

@Exelord Exelord merged commit fec752c into davewasmer:master Mar 15, 2021
@simonihmig
Copy link
Contributor Author

@Exelord seems you got into trouble with the Guthub actions config, sorry about that!

The config I used worked nicely when used with yarn. I quickly changed yarn to npm, but apparently missed changing to npm run, which you then fixed. Other than that it seems it is the same error that does not go away, even with your many changes afterwards: Cannot find module 'internal/util/types'. Looking at remy/nodemon#1124, it seems it is related to having an old version of npm, which indeed in CI is v3.5.4. Any idea why it is that old?

Other than that, we could switch to yarn maybe?

@Exelord
Copy link
Collaborator

Exelord commented Mar 17, 2021

yeah 😅 was trying to solve it but I failed at the end. The weird thing is, only the ember-try tests fail. It might be related to npm, thanks for pointing this out! I will try to upgrade it, otherwise will fallback to yarn (though I would like to stick to native)

@Exelord
Copy link
Collaborator

Exelord commented Mar 17, 2021

Screen Shot 2021-03-17 at 18 20 47
It looks like somehow ember-try is using wrong npm version, though the latest is installed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants