-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Drop support for Ember < 3.16, Node 6+8 #95
Conversation
Using `ember-cli-update`.
Seems Travis is not enabled by default anymore for OSS projects. Added a commit that sets up Github Actions. Although that will only get triggered once the config is in |
Hey @davewasmer, could you have a look at this (and #96) please? |
@simonihmig Unfortunately I'm no longer supporting any production Ember apps at the moment, so I'm not comfortable doing the code review / planning / maintenance here. I know @Exelord had taken over much of the work on this addon - perhaps they could chime in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) Though, before a release the new CI setup needs to be verified.
@Exelord seems you got into trouble with the Guthub actions config, sorry about that! The config I used worked nicely when used with Other than that, we could switch to |
yeah 😅 was trying to solve it but I failed at the end. The weird thing is, only the ember-try tests fail. It might be related to npm, thanks for pointing this out! I will try to upgrade it, otherwise will fallback to yarn (though I would like to stick to native) |
Using
ember-cli-update
to update dependencies and drop support for old versions.