Add Embroider support #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `ember-cli-update`.
Embroider does not support `postprocessTree` for type=all, but in this case the use of the `contentFor` hook seems even simpler, and works both in classic Ember CLI and Embroider.
simonihmig
force-pushed
the
embroider
branch
from
953746f
to
88fa775
Compare
|
I think this can be closed as it was addressed in #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embroider does not support
postprocessTreefor type=all, but in this case the use of thecontentForhook seems even simpler, and works both in classic Ember CLI and Embroider.Builds on top of #95, so that needs to get merged first. Best reviewed by looking at the second commit only.