-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ancestor/descendant algo #5326
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out, but I'd probably wait for Gerda's review before merging 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really my area of expertise; it looks like it passes the tests -- so I hope we have enough tests :)
I am going to merge this as @iknox-fa is ooo |
resolves #5286
Description
Updates ancestor/descendant algos to something more sane that also seems to correct an as-yet-undetermined root cause bug in either networkx or in the internal graph construction.
Checklist
changie new
to create a changelog entry