Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports: networkx, context cleanup #5335

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jun 6, 2022

Backports:

Let's include both of these in v1.1.1-rc2

@jtcohen6 jtcohen6 requested a review from leahwicz June 6, 2022 21:45
@jtcohen6 jtcohen6 requested review from a team as code owners June 6, 2022 21:45
@jtcohen6 jtcohen6 requested a review from iknox-fa June 6, 2022 21:45
@cla-bot cla-bot bot added the cla:yes label Jun 6, 2022
@gshank
Copy link
Contributor

gshank commented Jun 6, 2022

I thought 1.1 didn't have the networkx problem?

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jun 6, 2022

@gshank It didn't, but we're still using a less-than-ideal method (relative to new approach proposed in #5326).

Per conversation in #5286 (comment):

dbt-core v1.1 is still allowing networkx<3 (since this error didn't occur there). Since we don't feel like we fully understand exactly why the extra iteration step added in v1.1 is working, let's either:

#5286 (comment):

I like pinning 1.1 and not backporting since it's a change that introduces risk. We can add that to the RC2 that we are going to push out soon

@gshank
Copy link
Contributor

gshank commented Jun 6, 2022

Makes sense.

@stu-k stu-k requested a review from a team June 6, 2022 22:21
@jtcohen6 jtcohen6 merged commit 413a19a into 1.1.latest Jun 7, 2022
@jtcohen6 jtcohen6 deleted the backports/networkx-contexts branch June 7, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants