Throw error when building Iceberg tables without behavior flag set (#…

…1184)

* pipe the behavior through to relation in a temporary way to help with warnings in cli

* Adjust flag to new dbt-common setup.

* add changelog.

* Throw a compiler warning for iceberg model build without flag.

---------

Co-authored-by: VersusFacit <versusfacit@users.noreply.github.com>
Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>

.changes/unreleased/Under the Hood-20240917-181147.yaml

@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Change behavior flag semantics to log iceberg flag warnings..
+time: 2024-09-17T18:11:47.525026-07:00
+custom:
+    Author: versusfacit
+    Issue: "321"

dbt/adapters/snowflake/impl.py

@@ -80,7 +80,18 @@ class SnowflakeAdapter(SQLAdapter):
 
     @property
     def _behavior_flags(self) -> List[BehaviorFlag]:
-        return [{"name": "enable_iceberg_materializations", "default": False}]
+        return [
+            {
+                "name": "enable_iceberg_materializations",
+                "default": False,
+                "description": (
+                    "Enabling Iceberg materializations introduces latency to metadata queries, "
+                    "specifically within the list_relations_without_caching macro. Since Iceberg "
+                    "benefits only those actively using it, we've made this behavior opt-in to "
+                    "prevent unnecessary latency for other users."
+                ),
+            }
+        ]
 
     @classmethod
     def date_function(cls):

dbt/include/snowflake/macros/relations/table/create.sql

@@ -1,4 +1,9 @@
 {% macro snowflake__create_table_as(temporary, relation, compiled_code, language='sql') -%}
+
+  {%- if relation.is_iceberg_format and not adapter.behavior.enable_iceberg_materializations.no_warn %}
+    {% do exceptions.raise_compiler_error('Was unable to create model as Iceberg Table Format. Please set the `enable_iceberg_materializations` behavior flag to True in your dbt_project.yml. For more information, go to <url pending>.') %}
+  {%- endif %}
+
   {%- set materialization_prefix = relation.get_ddl_prefix_for_create(config.model.config, temporary) -%}
   {%- set alter_prefix = relation.get_ddl_prefix_for_alter() -%}