Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when building Iceberg tables without behavior flag set #1184

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Throw error when building Iceberg tables without behavior flag set #1184

merged 5 commits into from
Sep 18, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Sep 17, 2024 •
edited
Loading

Problem

We need to log the behavior flag for iceberg not enabled but it's difficult to keep this from spiraling into hundreds or thousands of entries.

This PR presents a patch for now until base adapter is worked on.

image

Solution

Monkey patch Relation.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Sep 17, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner September 17, 2024 19:29
@cla-bot cla-bot bot added the cla:yes label Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit changed the title More precise logging of iceberg flag warnings Log iceberg not enabled flag warning Sep 18, 2024
@VersusFacit VersusFacit changed the title Log iceberg not enabled flag warning Throw error when building Iceberg tables without behavior flag set Sep 18, 2024
@VersusFacit VersusFacit merged commit 0bfef5b into main Sep 18, 2024
15 checks passed
@VersusFacit VersusFacit deleted the add_behavior_flags_to_relation branch September 18, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VersusFacit @mikealfare @colin-rogers-dbt