Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seed truncate and overwrite to avoid append logic on unmanaged databases (#3) #916

Closed
wants to merge 10 commits into from
Closed

add seed truncate and overwrite to avoid append logic on unmanaged databases (#3) #916

wants to merge 10 commits into from

Conversation

machov
Copy link

@machov machov commented Oct 14, 2023

resolves #112

Problem

The current seed command in dbt-spark appends to existing seeded tables instead overwriting when the database is 'unmanaged' (no location specified from create schema)

Solution

Overwrite all rows from the existing seed tables and replace values.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

machov and others added 9 commits October 13, 2023 19:57
* Clean up changelog on main

* Bumping version to 1.8.0a1

* Code quality cleanup
changie commit

Mv1742 load csv table seed (#1)

* changie commit

* Update Fixes-20231013-120628.yaml
* insert overwrite instead of insert into for new seed runs

* Mv1742 load csv table seed (#1)

* changie commit

* Update Fixes-20231013-120628.yaml

* insert overwrite instead of insert into for new seed runs

changie commit

Mv1742 load csv table seed (#1)

* changie commit

* Update Fixes-20231013-120628.yaml

* Mv1742 rebase truncate (#2)

* merge remote

* add docs-issue workflow to dbt-spark (#913)

* Update seed.sql

* Update seed.sql

* add truncate table function

* rm changelog

* merge remote
@machov machov requested a review from a team as a code owner October 14, 2023 02:22
@machov machov requested a review from Fleid October 14, 2023 02:22
@cla-bot cla-bot bot added the cla:yes label Oct 14, 2023
@machov machov changed the title add seed (#3) add seed truncate and overwrite to avoid append logic on unmanaged databases (#3) Oct 14, 2023
@machov machov closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2084] Rerun dbt seed append data instead of refresh data if seed is stored in external table
2 participants