Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update not_null_proportion data test to use cross-database type_numeric() macro #800

Merged

Conversation

henriblancke
Copy link
Contributor

@henriblancke henriblancke commented May 22, 2023

resolves #553

This is a:

  • bug fix with no breaking changes

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • Athena
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
@henriblancke henriblancke changed the title [FIX] warehouse specific numeric type Update not_null_proportion test to use warehouse specific type May 22, 2023
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
@henriblancke
Copy link
Contributor Author

@joellabes would it be possible for you to take a look at his? Let me know if anything needs changing. Thanks!

@amacal
Copy link

amacal commented Oct 11, 2023

@henriblancke would you try to fix conflicts and try again. I hope someone will merge it.

Copy link

github-actions bot commented Apr 9, 2024

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 9, 2024
Copy link

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Apr 16, 2024
@dbeatty10 dbeatty10 removed the Stale label Apr 25, 2024
@dbeatty10 dbeatty10 reopened this Apr 25, 2024
@dbeatty10 dbeatty10 changed the title Update not_null_proportion test to use warehouse specific type Update not_null_proportion data test to use cross-database type_numeric() macro Jul 2, 2024
@dbeatty10 dbeatty10 added the bug Something isn't working label Jul 2, 2024
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @henriblancke !

The pre-existing tests are passing, so this looks good to me 👍

@dbeatty10 dbeatty10 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into dbt-labs:main with commit 3ea3dad Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not_null_proportion doesn't work in Athena / Presto due to numeric type
3 participants