Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update not_null_proportion data test to use cross-database type_numeric() macro #800

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Update not_null_proportion data test to use cross-database type_numeric() macro #800

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10a1aaa
[FIX] warehouse specific numeric type
henriblancke May 22, 2023
5cc5566
[ADD] changelog entry
henriblancke May 22, 2023
a81642f
Merge branch 'main' into fix-numeric-type-not-null-prop
henriblancke Jun 12, 2023
42c5787
Merge branch 'main' into fix-numeric-type-not-null-prop
henriblancke Oct 11, 2023
8eea382
Merge branch 'main' into fix-numeric-type-not-null-prop
dbeatty10 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion macros/generic_tests/not_null_proportion.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
with validation as (
select
{{select_gb_cols}}
sum(case when {{ column_name }} is null then 0 else 1 end) / cast(count(*) as numeric) as not_null_proportion
sum(case when {{ column_name }} is null then 0 else 1 end) / cast(count(*) as {{ dbt.type_numeric() }}) as not_null_proportion
from {{ model }}
{{groupby_gb_cols}}
),
Expand Down