Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update legacy dbt dependency spec to cover future requirements #571

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jun 7, 2023

Our legacy dbt integration laid out a bunch of optional dependencies
on dbt core 1.4 plus various adapter packages.

The integration plan for MetricFlow 0.200.0 involves a dependency
link with dbt core 1.6 in order to enable query execution through
dbt adapters and reading from dbt project metadata for parsing
the semantic manifest.

This commit removes the legacy dependency structures and adds a
temporary dependency on dbt core 1.5. For the purposes of our
current integration steps 1.5 is adequate, and at the moment the
1.6 beta releases do not appear to be published for all of the
adapters we want to test.

@cla-bot cla-bot bot added the cla:yes label Jun 7, 2023
Copy link
Contributor Author

tlento commented Jun 7, 2023

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Our legacy dbt integration laid out a bunch of optional dependencies
on dbt core 1.4 plus various adapter packages.

The integration plan for MetricFlow 0.200.0 involves a dependency
link with dbt core 1.6 in order to enable query execution through
dbt adapters and reading from dbt project metadata for parsing
the semantic manifest.

This commit removes the legacy dependency structures and adds a
temporary dependency on dbt core 1.5. For the purposes of our
current integration steps 1.5 is adequate, and at the moment the
1.6 beta releases do not appear to be published for all of the
adapters we want to test.
@tlento tlento requested a review from plypaul June 7, 2023 22:35
@tlento tlento marked this pull request as ready for review June 7, 2023 22:35
@tlento tlento merged commit f57cd53 into main Jun 8, 2023
@tlento tlento deleted the update-dbt-deps branch June 8, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants