Remove support for async queries from SqlClient #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of query cancellation relies heavily on the async query interfaces, which we are removing in favor of making MetricFlow a single threaded single query execution library. We may need to bring the cancel method back in some form, but it'll be more similar to what we see in libraries like the dbt adapter library, where each client implements a "cancel all queries for a given connection" kind of interface. This commit removes the cancel method to streamline the process of removing the async query and async execute commands.
This was referenced Jun 9, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
We will not be using async query dispatch mechanisms going forward, so this removes the relevant methods and all supporting methods and classes.
tlento
force-pushed
the
remove-async-query-support
branch
from
069fd0d
to
fa2c9e5
Compare
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
approved these changes
Jun 9, 2023
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricFlow is moving in the direction of providing a single thread for query
compilation and dispatch, and leaving all concurrency concerns to calling
applications. We are doing this in part to streamline and simplify our current
interfaces, and in part to make sure MetricFlow can easily integrate with
external libraries, like dbt adapters.
We may choose to revisit this decision at a later time, but for now we will be
removing all support for async query methods.
This PR also removes support for the existing query cancel methods, as those were
largely tied to the async query implementations. There are other options for
supporting cancelling running queries, but until we cut over the MetricFlow core
package to use dbt adapters for query dispatch we will not support this functionality.