Move snapshot files to enumerated paths #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetricFlow has sets of query planning and dialect rendering tests that compare against snapshot files representing plans and SQL queries. For dialect-specific constructs, we rely on a dialect- specific snapshot file. For historical reasons, these were stored in a path location bound to the SqlClient class used in the tests. Now that we are moving to a model where we delegate this work to dbt adapters, we will be re-using the same SqlClient class for multiple dialects. More generally, we'd like to separate our warehouse client from our dialect operations. So this commit moves the relevant files to a path based on the target engine property of the SqlClient interface. Since our dialects currently map on to supported engines 1:1, we can do this for now, and eventually convert to dialect-only differentiation in the future.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
|
DuckDB and Postgres passed locally, running other warehouse tests in CI, will fix up anything that goes awry. |
plypaul
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricFlow has sets of query planning and dialect rendering tests
that compare against snapshot files representing plans and SQL
queries. For dialect-specific constructs, we rely on a dialect-
specific snapshot file. For historical reasons, these were stored
in a path location bound to the SqlClient class used in the tests.
Now that we are moving to a model where we delegate this work to
dbt adapters, we will be re-using the same SqlClient class for
multiple dialects. More generally, we'd like to separate our
warehouse client from our dialect operations. So this commit
moves the relevant files to a path based on the target engine
property of the SqlClient interface. Since our dialects currently
map on to supported engines 1:1, we can do this for now, and
eventually convert to dialect-only differentiation in the future.
Note - this was done via file moves in the IDE, which seem to
be the equivalent of
git mvunder the hood.